[Adduser-devel] Bug#341202: adduser: gecos option: only last field is set

[Christian Gennerat]

Package: adduser
Version: 3.77
Severity: important
Tags: patch

Problem:
chfn puts default value for all non-specified fields.
only the last call to chfn have effect.

Solution:
do only one call to chfn

Proposed code:


sub ch_gecos {
    my $gecos = shift;
    my @gparm=('-f', $gecos);    
    if($gecos =~ /,/)
      {
	my($gecos_name,$gecos_room,$gecos_work,$gecos_home,$gecos_other)
	    = split(/,/,$gecos);
	@gparm=('-f', $gecos_name, '-r', $gecos_room);    
	push(@gparm,'-w', $gecos_work)
	    if(defined($gecos_work));
	push(@gparm,'-h', $gecos_home)
	    if(defined($gecos_home));
	push(@gparm,'-o', $gecos_other)
	    if(defined($gecos_other));
      }
    &systemcall('/usr/bin/chfn', @gparm, $new_name);
}


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: i386 (i586)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.4.23
Locale: LANG=fr_FR at euro, LC_CTYPE=fr_FR at euro (charmap=ISO-8859-15) (ignored: LC_ALL set to fr_FR at euro)

Versions of packages adduser depends on:
ii  debconf [debconf-2.0]         1.4.59     Debian configuration management sy
ii  passwd                        1:4.0.13-1 change and administer password and
ii  perl-base                     5.8.7-7    The Pathologically Eclectic Rubbis

adduser recommends no packages.

-- debconf information:
* adduser/homedir-permission: true