[Adduser-devel] Bug#451321: Bug#451321: adduser: deluser should not rewrite backup files

Stephen Gran sgran at debian.org
Thu Nov 15 01:18:25 UTC 2007


This one time, at band camp, Kris Kvilekval said:
> 
> The original backup code in deluser first writes the tar file, and then compresses it.
> This patch simply uses some gnu tar options (already required) to accomplish
> the same.   This is useful when backup up over NFS.
>   	  if($bzip2) {
> ! 	      $options .= "--bzip2";
> !               $ext = ".bz2";
>   	  } elsif($gzip) {
> ! 	      $options .= "--gzip";
> !               $ext = ".gz";
>   	  }
> + 	  &systemcall($tar, "-c" , $options, "-f", $backup_name.$ext, "--files-from", $filesfilename);

This will leave a file named '$backup.tar.' in the case that both of those
compressors are missing, I think.  Otherwise, it seems reasonable.  I'll
look at merging it in shortly.

Thanks for the report,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran at debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20071115/5aaf1af3/attachment.pgp 


More information about the Adduser-devel mailing list