[Amavisd-new-debian-devel] the debian l10n template feature

[Harald Jenny]

On Sun, Sep 11, 2011 at 12:37:07AM -0300, Henrique de Moraes Holschuh wrote:
> On Sun, 11 Sep 2011, Henrique de Moraes Holschuh wrote:
> > On Fri, 09 Sep 2011, Harald Jenny wrote:
> > > > > > > Can you confirm that what I've done is correct and complete?
> > > > > > Narf. I haven't reviewed this yet. But please don't commit into master if is
> > > > > > not your package and you want a review.
> > 
> > I.e. do the work in a topic branch...
> > 
> > > > > My commit just extends your work on the extract-upstream-en_US-templates.pl
> > > > > script and applies the results from it to the two old template-spam-* files,
> > > > > IMHO there is no real need to review these changes as there basically update
> > > > > some wordings in the two files but if you disagree theses changes can be
> > > > > reverted. The patch I attached was produced in a local temporary respository.
> > > > > But if you feel more comfortable I can in the future just send patches in to
> > > > > allow for previous review by others.
> > > > Just create a branch and ask for a pull. 
> > > 
> > > I have created a local branch for the logfile issue called seperate_logfile -
> > > when I have finished it should I push it to the amavisd-new alioth repository?
> > 
> > Either that, or publish it somewhere and ask for a pull.
> > 
> > > Btw could you comment on the patch attached in one of my previous emails if it
> > > is correct and sufficiant so I can mail it upstream?
> > 
> > I am going to try to do that right now.
> 
> The l10n ones look fine (although I did NOT runtime-tested them).
> 
> If you have runtime-tested the l10n changes, I'd say we can apply them and
> send them upstream as well.

For runtime tests I have to setup a new non-production VM which I did not yet
find the time to do, hope it will work out later this week.

> 
> -- 
>   "One disk to rule them all, One disk to find them. One disk to bring
>   them all and in the darkness grind them. In the Land of Redmond
>   where the shadows lie." -- The Silicon Valley Tarot
>   Henrique Holschuh