[Aptitude-devel] Bug#708812: Bug#708812: [aptitude] aptitude segfaults upon being called.

[Axel Beckert]

Hi Andi,

Andreas Barth wrote on Sat, 17 Aug 2013 17:24:51 +0200:
> > > > > can you please upload a new aptitude version? Or should I just NMU
> > > > > aptitude with the required patches for gcc-4.8?
> > > > 
> > > > You are aware of that it needs more than just the patches for gcc-4.8
> > > > to get aptitude build again properly?
> > > 
> > > I built (and installed and run) aptitude successfully on mipsel prior
> > > to my NMU of google-mock. Might be that I had luck or whatever - I
> > > will try this built now in a current chroot and see what happens.
> > 
> > Just rebuilt and it works fine. I will make proper packages from that,
> > plus provide the patches I used somewhere, so you could review what I
> > did.
> 
> Works. I put up the source package for inspection on
> http://alius.ayous.org/~aba/.aptitude/
> 
> If wanted, I could upload the full package into unstable (or if I
> don't get a no, I will upload it in a week).

Ok for me. Helps the porters.

I though haven't heard anything from Daniel about this so far.

> The relevant patch is below.
[...]
> diff -Nru aptitude-0.6.8.2/debian/patches/aptitude-0.6.8.2-1.1 aptitude-0.6.8.2/debian/patches/aptitude-0.6.8.2-1.1
> --- aptitude-0.6.8.2/debian/patches/aptitude-0.6.8.2-1.1	1970-01-01 00:00:00.000000000 +0000
> +++ aptitude-0.6.8.2/debian/patches/aptitude-0.6.8.2-1.1	2013-08-17 11:39:40.000000000 +0000
> @@ -0,0 +1,63 @@
> +Description: necessary change to make aptitude buildable in sid again
> +   * cherrypick from git:
> +     + 794b91 fix FTBFS with g++-4.8
> +     + c142a7 task_list is not extern
> +Author: Andreas Barth <aba at ayous.org>

I'd have put the two cherry-picked commits into separated and less
vacuously named patches. And I also wouldn't have attributed the
patches to myself but to the actual author(s) of the two commits.

But as the NMU probably won't be part of the next maintainer-upload
and because it is only there to bridge the gap to the next upload for
the mipsel porters, it shouldn't be such an issue.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5