[Babel-users] [PATCH 2/2] Add filter to choose the export routing table.

Juliusz Chroboczek jch at pps.univ-paris-diderot.fr
Sat Oct 31 03:23:41 UTC 2015


> --- a/kernel_netlink.c
> +++ b/kernel_netlink.c
[...]
> +#include "configuration.h"
[...]
> +    export_filter(dest, plen, src, src_plen, ifindex, &filter_result);

Wrong layering -- the filtering stuff doesn't belong in kernel_netlink,
which is supposed to be a thin layer above the kernel.  (And yes, I still
believe you did it wrong by putting disambiguation at this level.)

Applying the filter should happen in route.c, and kernel_route should take
the table number as a parameter.

-- Juliusz



More information about the Babel-users mailing list