[Bash-completion-devel] Bug#512556: bash-completion: awk syntax error on 'modprobe -r /<tab>'

Colin Watson cjwatson at ubuntu.com
Wed Jan 21 18:31:20 UTC 2009


Package: bash-completion
Version: 20080705
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch jaunty

This bug was originally filed as
https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/316654.

Typing 'modprobe -r /<tab>' produces the following output:

  $ modprobe -r /awk: {if (NR != 1 && $1 ~ /^//) print $1}
  awk:                          ^ syntax error

I've attached a bzr bundle fixing this, based on a patch by Martin Mai.
You can merge it with 'bzr merge
/path/to/bash-completion-modprobe.bundle'.

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]
-------------- next part --------------
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: cjwatson at canonical.com-20090121182546-2gpf8kdmochssoys
# target_branch: lp:bash-completion
# testament_sha1: 4b3a9aabe5570a411f664c851ad972507df1b506
# timestamp: 2009-01-21 18:26:10 +0000
# base_revision_id: guillomovitch at zarb.org-20090120205241-\
#   90lzvb77z373k070
# 
# Begin patch
=== modified file 'bash_completion'
--- bash_completion	2009-01-19 20:30:58 +0000
+++ bash_completion	2009-01-21 18:25:46 +0000
@@ -835,6 +835,12 @@
 	cur=`_get_cword`
 	prev=${COMP_WORDS[COMP_CWORD-1]}
 
+	# do filename completion if we're giving a path to a module
+	if [[ "$cur" == */* ]]; then
+		_filedir '@(?(k)o?(.gz))'
+		return 0
+	fi
+
 	# behave like lsmod for modprobe -r
 	if [ $1 = "modprobe" ] &&
 	   [ "${COMP_WORDS[1]}" = "-r" ]; then
@@ -843,12 +849,6 @@
 		return 0
 	fi
 
-	# do filename completion if we're giving a path to a module
-	if [[ "$cur" == */* ]]; then
-		_filedir '@(?(k)o?(.gz))'
-		return 0
-	fi
-
 	if [ $COMP_CWORD -gt 1 ] &&
 	   [[ "${COMP_WORDS[COMP_CWORD-1]}" != -* ]]; then
 		# do module parameter completion

=== modified file 'debian/changelog'
--- debian/changelog	2009-01-19 10:53:34 +0000
+++ debian/changelog	2009-01-21 18:25:46 +0000
@@ -99,7 +99,11 @@
   * Add .mp2 and .vdr to mplayer completion (RHBZ: #444467).
   * Add .mkv, .mp2 and .vdr to *xine completion (RHBZ: #444467).
   * Added lzop completion.
-  
+
+  [ Colin Watson ]
+  * modprobe: Check for */* before checking for 'modprobe -r', to avoid
+    spewing an awk syntax error (thanks, Martin Mai; LP: #316654).
+
  -- David Paleino <d.paleino at gmail.com>  Sat, 17 Jan 2009 19:01:16 +0100
 
 bash-completion (20080705) unstable; urgency=low

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWRmelf8AAj9fgEAwXff//9oG
QIq//9/wUAUMPOBRmADbFjhkqPRGTQyAwgNABoYTQAAJJBMIBGShoyNNPUZGJiNMRo0ASmiEEKey
U9TbUaRsp6jeigDaJpp6mQBzAATJgATCYJhDAEYAEkqeRMTAI0yNTak2U8amUZAAaaaaNhSipAnN
m6vwsTPLOjHUQJ0ff7i/LvpUyuUNBGMUDSliZJjJt2qLMueizamo3z3GH5a1FMXMD0tTtNYkmSH6
G8ZWou5mhRMd8EeeY9ucu3mU6xGj7Pj1d7Igg0jr2/wcnQ5N5v7Ovplb4PRa1CDNYOFyOV5PZr5r
a9mE9D3xLrOibxhsYIyXwDcJmjyfG4dufs4w6N9P9wM3FqBSe89TvVyvKmBgMgLlRgT43qcrzRZv
6I+fmHHiolpKuO0+yJiFC7sXJzFSY3iDVpRvTAZnBQaG5PUGXQ6BI4lRSTIUyqkw4vOU6b13YqjK
4ec1VAsasMgJgGdL747Y9/WZJxA0LF2tQCORzaQIPvqtxf2UNWM7X7GEFy1inJEMDWsyNt6eBnM6
ltNDUoh48wGMQOBPrbnn1myGLr9mdD4q0nlEay0cbdImpav2ToYMqLaYqZQgY4DWFCYFGWisJGwg
ZEq2ZFIp2Vw3JBVbfQcsgIrEcn8EioqLCFUzURxPZmQXmA8sl3khCOpNQ4iIhgnMi9YxTSOGCeUH
FyzHVDAsU8mfVO7iT09BEUXGBN15sJjipYBmQLHFUL1J5iN5ypsNrF5YTMC/+LyJEVaV3KgTCL1g
iPGeHOejvN7JeDHbjerkqxYxpQuAg6d3Y2/3xU5Unj7/LjRgjeF9SQI8cpYoQ3kI5JsFW3hYZDSn
YWeci5FRiSG3HUcjvOR4OMJ5jajzPr1QQ8LArrHRVIzoP9TQEiUp4KZO9D8oJgnPCcOp6rt9rby8
YjLrlhD8lvA7CYY1kJee4PE8Dcg8kHQx9l4QU2tpNQH8ePBi0qz5j4CIj1XpAQffkFJfuLisHA30
IxWmRXViZe1U5L6Aarxd2RvMnGbnmLfkcCwg/UHIgJBwxdQSrzKtpwagejV2MHN8tkx+HxLPmg6J
hRzy9LjYGJWpAjEPM6HwVtpMCU7io2HaaAOh37TcbVMvHyOJaZN2sGkZai/nAjgtgcUnLP7rQP9s
jyY648qWChMwmTjyh9R49gLtSHVFfOxBmbSWihLrbFHoAwCEgY4HVE/LqOLfzuhjukBgJ5ELd0eT
c9NFwJhp+a15AXIgHvNe9gJQpWt6T25BMOcD9apDLsXI/nVBGvrVodXDecpwTzA+5xeLQCu9OD26
OwuQ6wTCTASqaJMSQzs7Bp9EEkwU7xNCGTR7NzUemEwVgma5cDDkdqQ8GDEnQMgYPGRBIicYYnQx
3gy0OWqcOBoAtTtcbbt20HQKMIjEBwSndheGjQNpkFshoNqeiOALBxjwellLlYTsorDJW7Zrg1Sc
MCgZSpyjtsG2iJSEtRwbnwsZyuXmQMSSUgPLbU7AGmLjDQt7Fwweez6Bc4xB+FAlLnH67hwxgDla
i0OViLBNIulA4uPFDOfTfjvVqrVBgFwx0oMeiJbYHuVIIvuaxOc4qAG5ixIBIa5ZuH+LuSKcKEgM
z0r/gA==


More information about the Bash-completion-devel mailing list