[Bash-completion-devel] Bug#512917: dh_bash-completion: unexpected behaviour

[gregor herrmann]

On Thu, 29 Jan 2009 14:53:33 +0100, David Paleino wrote:

> > Please consider changing the behaviour of dh_bash-completion for
> > future releases.
> Would you mind helping in some beta-testing? :)

Sure!

> http://bzr.debian.org/loggerhead/bash-completion/current/revision/1291?

That was quick, thanks!

I've tried all three possibilities (using a snippet, naming a source file
and naming a source file + install file), and: all three work -
congratulations!

The only glitch I had when listing a file (with or without install
name) is a lintian warning (executable-not-elf-or-script) because the
original permissions are taken (which are 755 in my test case); the
"snippet version" sets them to 644. The following trivial patch fixes
this problem:

--- dh_bash-completion~	2009-01-29 17:24:19.000000000 +0100
+++ dh_bash-completion	2009-01-29 17:25:39.000000000 +0100
@@ -93,7 +93,7 @@
 			}
 
 			foreach my $src (@filelist) {
-				doit("install", "-p", $src, "$bc_dir/$name");
+				doit("install", "-p", "-m644", $src, "$bc_dir/$name");
 			}
 		}
 	}


But besides that it looks really nice!

Cheers,
gregor
-- 
 .''`.   Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
   `-    NP: U2: Grace
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/bash-completion-devel/attachments/20090129/c831f738/attachment-0001.pgp