[Bash-completion-devel] [bash-completion-Bugs][313018] completion for puppet

bash-completion-bugs at alioth.debian.org bash-completion-bugs at alioth.debian.org
Sat Feb 26 14:00:15 UTC 2011


Bugs item #313018, was changed at 2011-02-23 16:21 by Ville Skyttä 
You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=313018&group_id=100114

>Status: Closed
Priority: 3
Submitted By: Mathieu Parent (sathieu)
>Assigned to: Guillaume Rousse (guillomovitch-guest)
Summary: completion for puppet  
Distribution: --Distribution-Agnostic--
Originally reported in: None
Milestone: None
>Status: Fix Committed
Original bug number: 


Initial Comment:
The attached file adds completion for puppet and related (puppetmasterd puppetd puppetca ralsh puppetrun puppetqd filebucket puppetdoc puppet)

It has been tested on Debian Squeeze.

----------------------------------------------------------------------

>Comment By: Ville Skyttä  (scop-guest)
Date: 2011-02-26 16:00

Message:
Closing per previous comment.

Just one remark: is the -o filenames intentional? In most cases we don't need to nor should do that because _filedir handles it internally and -o filenames can cause problems when applied to all completions.

----------------------------------------------------------------------

Comment By: Guillaume Rousse (guillomovitch-guest)
Date: 2011-02-23 22:44

Message:
Thanks, I just pushed it, with a few changes (mostly cosmetics).

----------------------------------------------------------------------

Comment By: Todd Zullinger (tmz-guest)
Date: 2011-02-23 17:55

Message:
I'm a bit unfamiliar with alioth, as I can't figure out how to add a new attachment.  But I think the cert_list command can be simplified.  I replaced the sed command (which did not work properly in my testing) with: awk '/^[+-] / {print $2}'

That's a little easier on the eyes and gets the proper certs in my case.  To be most accurate, for --revoke actions, only entries beginning with + should be included, as revoking already revoked certs is a bit pointless. ;)

Thanks for working on this Mathieu.

----------------------------------------------------------------------

Comment By: Mathieu Parent (sathieu)
Date: 2011-02-23 17:21

Message:
Here is a new version which should handle puppet 0.25.

Only tested on squeeze.

----------------------------------------------------------------------

Comment By: Todd Zullinger (tmz-guest)
Date: 2011-02-23 16:39

Message:
Looks like it could be handy.  Using puppetca --revoke <tab> with puppet-0.25.x yields "invalid option: --all" because it calls puppet cert, which doesn't exist until puppet-2.6.  I don't know if it's worth trying to handle that better or not.

----------------------------------------------------------------------

You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=313018&group_id=100114



More information about the Bash-completion-devel mailing list