[Bash-completion-devel] [SCM] bash-completion branch, master, updated. 1.90-54-gf0283e1

[Ville Skyttä]

On 11/20/2011 06:47 PM, Igor Murzov wrote:
> On Sun, 20 Nov 2011 16:39:54 +0200
> Ville Skyttä <ville.skytta at iki.fi> wrote:
>
>> BTW I believe we've until now used pretty consistently $( foo ) instead
>> of $(foo) but this commit introduces a bunch of the latter, making
>> things somewhat less consistent wrt. this than before.
> 
> Hm, I haven't seen any rule for that and there were lots of $(foo) already. I preferred to use $(foo) instead of $( foo ), because former is more terse and ( $( foo ) ) looks very sparse.

Some ballpark numbers:

$ git grep -c '\$( [^(]' bash_completion completions | \
awk -F: '!/Makefile/ { sum += $2 } END { print sum }'
1377

$ git grep -c '\$([^( ]' bash_completion completions | \
awk -F: '!/Makefile/ { sum += $2 } END { print sum }'
175

Before the patch being discussed the numbers were about 1428 vs 124.  I
have a strong opinion that we should be and stay consistent wrt style
issues, whether the "rules" are written somewhere or not.  I don't care
that much which of these it is, as long as it is consistent, but for
historical reasons I'd personally prefer the "sparse" one.