[Bash-completion-devel] [PATCH] Fix lvm completion related with physical volumes

Ville Skyttä ville.skytta at iki.fi
Sun Feb 7 08:46:03 UTC 2016


On Wed, Dec 16, 2015 at 5:21 AM, Liuhua Wang <lwang at suse.com> wrote:
> There are the following problems with lvm completions:

Thanks for the patch and sorry about the delay. I don't use lvm myself
-- any lvm users around to review this?

In any case, please add test cases for the changes to the extent it
makes sense (and make sure they're properly skipped or fail gracefully
on non-lvm systems). Also, your change appears to cover three changes,
would be better to split the change to three different commits (again
if it's sanely doable), each doing one thing.



More information about the Bash-completion-devel mailing list