[Build-common-hackers] Bug#486848: Bug#486848: cdbs binary-arch, binary-indep targets should depend the build target (per Debian Policy 4.9)

[Jonas Smedegaard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Wed, Jun 18, 2008 at 04:07:49PM +0100, Noah Slater wrote:
>In the situation where the package needs to be built before the binary 
>package can be prepared, making the `binary` target will fail because 
>CDBS does not have the `binary-arch` or `binary-indep` targets 
>depending on `build`.

Some rules are secured to be invoked serially, others are not.  This 
concrete example does not relate to above, but to a debhelper-specific 
rule not promised to to be invoked at a certain time.


>I am working on a lockrun package through Debian mentors which you can 
>grab:
>
>  dget http://mentors.debian.net/debian/pool/main/l/lockrun/lockrun_0~20080520-1.dsc
>
>The debian/rules can be viewed directly via:
>
>  http://svn.debian.org/wsvn/collab-maint/deb-maint/lockrun/trunk/debian/rules?op=file&rev=10271&sc=1

Above packaging fails because the build target 
common-install-prehook-impl wrongly expects to be invoked after all 
building has finished (not in parallel).

If you really want to abuse build targets like that, you can add the 
missing dependency by changing

   common-install-prehook-impl::

to

   common-install-prehook-impl:: build

A better fix, however, is to use the more appropriate targets 
build/lockrun:: and install/lockrun:: instead.


Kind regards, and sorry for the late response.

  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCgAGBQJKWKgdAAoJECx8MUbBoAEhyNoQAJWLVS5scuFvoRaSnXWnGrON
M10DSh2oM85p2Za+Sn0uPZpXv6iDRXTp9yZvpqbwZdN0rjewtVcWp+LO71F2LrHW
ZeP2z77d/c0+VpDcMx5tbYEWoE4TqtkLr2/Hp32drC8e4U1ObdJ+PitmjN71xce1
3qTdAool1wye5J+ZOZRjD0n9IQgKldUvyDJVm7M42Kwt6l0R5QmEaAIgmtlL6/0/
9svETPF05vElhk9at5yhJC6ZaI9bo73ij8acr4SoWTT0SuHkFYTKwaLNH4HH2FMM
11r8+8hiuytpgZvM2qmue5c9+7EvvqpzAAlnhhImnaD1SdJbS0T9L65qOjF+zgKo
O3McI6d0GUpXGX7XRlHF4QC0uaiRRKXLupvsF/ci55Rr0Gt1MVjliklooUrD37Nq
J62pVl2ESbWYPcOziyD59/yi7CpQbP35bbIVuUgjVDxrmdfIhdCjio3NYGvUYqGY
/g+LLK6XL/QYQADeB4h99joRPmlnxgurie5NbIbBgv/g5J08DJfHXrl9lmYT/73+
a4u7JtUf6mdIu1cwkNt9yQ5U4XsZG9EvTwKJ2zBPXFhSsawXqNo4hrfh8W9gE9nP
nxmmYN3J5YDbNi5ry4X+wSAoQFOQs0DJ7W/wPJXA6ZaQnfDw96j0k5LUCiVKl6St
AMQQQhWb2BLQdhHmphNx
=N8s5
-----END PGP SIGNATURE-----