[Build-common-hackers] Bug#712729: Bug#712729: cdbs: langcore.mk: support dpkg-buildflags' DEB_CFLAGS_MAINT_APPEND and similar

[Emilio Pozuelo Monfort]

On 20/06/13 09:57, Jonas Smedegaard wrote:
> Quoting Emilio Pozuelo Monfort (2013-06-20 00:29:14)
>> On 19/06/13 19:14, Jonas Smedegaard wrote:
>>> Quoting Emilio Pozuelo Monfort (2013-06-19 11:29:55)
>>>> Or
>>>>
>>>> DEB_LDFLAGS_MAINT_APPEND = -Wl,-O1 -Wl,--as-needed
>>>>
>>>> and get my package built with LDFLAGS="dpkg build flags plus my 
>>>> other flags".
>>>>
>>>> There are other kind of DEB_LDFLAGS_MAINT_ vars, which are 
>>>> _PREPEND, _SET and _STRIP. CDBS should honor all of them so if I 
>>>> set one, I will get the right flags.
>>>
>>> Anyone wanting that logic can simply do this:
>>>
>>>   include /usr/share/dpkg/buildflags.mk
>>>
>>> No need for CDBS to replicate code provided by dpkg IMO.
>>
>> Perhaps CDBS' buildflags can include that file and let it do its 
>> magic. But that may or may not be possible as it may unconditionally 
>> set *FLAGS (I don't remember and can't check right now). I thought 
>> it'd be cool if one wouldn't need to do extra includes. But I 
>> understand it may not be straightforward and not worth it.
> 
> How do you mean? How can buildflags include a file?!?

Sorry, s/buildflags/langcore/. By 'that file' I meant dpkg's buildflags.mk. But
of course that may not be possible without breaking backwards compatibility as
buildflags.mk unconditionally sets *FLAGS.

Emilio