[Buildd-tools-devel] Bug#477937: Bug#477937: double check for repo type

[Roger Leigh]

martin f krafft <madduck at debian.org> writes:

> I am experimenting with a new backend storage type for schroot: git.
>
> I noticed that setup.d/00check checks the type of the chroot and
> errors if the type is unsupported. Thus, I extended the case
> statement, but unfortunately found that schroot itself also seems to
> check:
>   
>   $ schroot -vc bpo40-i386-git
>   E: /etc/schroot/schroot.conf: Unknown chroot type ‘git’
>
> I'd say the binary shouldn't run this check. If only 00check does
> it, then schroot can be freely extended without the need to
> recompile.

The chroot type is not just something used by the scripts--it's a
class in the source code which defines its properties in the
configuration file as well as some aspects of its behaviour.  To add a
new type you would need to derive a new type e.g. sbuild::chroot_git
and add that into the sbuild::chroot factory function that
instantiates chroot objects.

sbuild::chroot::create (Line 117)
http://git.debian.org/?p=buildd-tools/schroot.git;a=blob;f=sbuild/sbuild-chroot.cc;h=ece51beae88242fb5d4f6af25b9c7fc5d986ef5e;hb=HEAD


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20080426/c1ad9c4e/attachment.pgp