[buildd-tools-devel] Bug#551311: Bug#551311: Updated patches for debuild like functionality in sbuild.

[Roger Leigh]

On Wed, Dec 09, 2009 at 01:50:12AM +0000, Roger Leigh wrote:
> On Thu, Nov 12, 2009 at 11:30:18PM -0500, Andres Mejia wrote:
> > On Tuesday 27 October 2009 01:22:14 Andres Mejia wrote:
> > > On Friday 23 October 2009 19:23:59 Andres Mejia wrote:
> > > > Here are a new set of patches for some debuild like functionality
> > > >  implemented directly in sbuild. Details of what's new is in the patch
> > > > for the man page but in short, sbuild would now be able to build from a
> > > > Debianized source package, run lintian after a build, and run external
> > > > commands before and after a build.
> > > >
> > > > With this, the sbuild-debuild script and manpage can be removed.
> > > 
> > > Something I forgot to include was cleaning the source directory before
> > > building the source packages. Here's a patch that fixes that.
> > > 
> > 
> > Were these patches reviewed? No rush, just wondering.
> 
> Right, I've spent a few hours reviewing them tonight.  It's the first
> free time I've had in a while, so apologies for the delay.
> 
> Firstly, I've attached an updated copy of the patches.  These are
> exactly the same as yours, but merge conflicts with current git
> are fixed.  I've then gone through the patches and my comments
> follow for each patch in turn.
> 
> Before I go into the criticism in detail, I just want to say that
> overall I'm really happy with the idea behind the patches, and
> would have applied them straight away.  However, there are a few
> issues which need working on first.  These are mostly simple to
> resolve, so it shouldn't be hard to fix them to go in.  The major
> issue is shell quoting which can cause potential problems due to
> assuming that options and command paths never contain spaces,
> which is easy to fix.

OK, first patch attached, which follows on from your patch set.
This switches the configuration file Sbuild::Conf and ::Options
to handle array references as storage rather than scalars.

My next patch will teach Sbuild::Build to use arrays for
program execution with system.


-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20091209/826a0e59/attachment-0001.pgp>