[buildd-tools-devel] Bug#551311: Bug#551311: Updated patches for debuild like functionality in sbuild.

[Andres Mejia]

On Saturday 12 December 2009 20:22:11 Roger Leigh wrote:
> On Sat, Dec 12, 2009 at 06:18:43PM -0500, Andres Mejia wrote:
> > On Saturday 12 December 2009 05:52:12 Roger Leigh wrote:
> > > On Sat, Dec 12, 2009 at 12:42:10AM -0500, Andres Mejia wrote:
> > > > On Friday 11 December 2009 07:17:04 Roger Leigh wrote:
> > > > > On Thu, Dec 10, 2009 at 09:38:08PM -0500, Andres Mejia wrote:
> > > > > > First I would like to say, thank you for reviewing my patches. :)
> > > > > >
> > > > > > Next I would like to say, please don't attach any patches inline
> > > > > > anymore. I spent way too much time ripping out the patch from my
> > > > > > email client and then had to properly format the patch just to
> > > > > > get it to apply.
> > > > >
> > > > > Thanks for the updated patch.  I've attached what I currently have,
> > > > > but I've not yet merged all of your changes into it yet.
> > > > >
> > > > > This applies after my first patch (it replaces the second patch).
> > > > >
> > > > >
> > > > > Regards,
> > > > > Roger
> > > >
> > > > It didn't apply cleanly for me. I noticed the first hunk from the two
> > > > patches adds "use Sbuild::ChrootRoot;", so I figure there's already
> > > > some problem with the patch. I'll just wait until it's applied to the
> > > > git tree rather than attempt to fix the patch again. I'll report
> > > > problems then.
> > >
> > > I've put all the current changes at
> > >   git://git.debian.org/users/rleigh/sbuild.git
> > > branch "debuild-am"
> > >
> > > It's working for me so far.
> > >
> > > > One thing I found wrong was the pipe_command() call for
> > > > dpkg-parsechangelog. The hash needs to have 'DIR => getcwd()', else
> > > > it will fail.
> > >
> > > I think this was caused by something else, since getcwd() is the
> > > default.  It's working for me without this.
> >
> > I don't know why, but for some reason, it wants to default to using "/"
> > as DIR in my system. I've even tried this on a pure checkout of the
> > debuild-am branch. I am running this through Debian sid, if that helps.
> > I've attached the patch that fixes this for me.
> 
> Are you using the libs in lib/ when testing (PERL5LIB=lib ./bin/sbuild
>  ...)? Otherwise you might be using a copy of the system modules.

I'm using perl directly with appropriate options. As in,

$ perl -Isbuild/lib sbuild/bin/sbuild sbuild

> DIR does default to "/" in Chroot.pm, new() line 65.  However, in Build.pm,
> this is overridden in run() line 253:
> 
>     my $chroot_defaults = $session->get('Defaults');
>     $chroot_defaults->{'DIR'} =
>         $session->strip_chroot_path($session->get('Build Location'));

Yes, this is the problem. You sure you pushed all your changes? I don't see 
this line in the debuild-am branch and I just verified this is the case via 
http://git.debian.org/?p=users/rleigh/sbuild.git as well.

> While your patch does work around this, I'm reluctant to apply it
> because it's indicative of something else being the real problem.
> I checked myself with a new checkout and it works fine for me:
> 
> % git clone git://git.debian.org/users/rleigh/sbuild.git
> % cd sbuild
> % git checkout -b debuild-am origin/debuild-a
> % ./bootstrap
> % ./configure
> % make
> % PERL5LIB=lib ./bin/sbuild -s -A -d unstable --run-lintian
>  dadadodo_1.04-3.1
> 
> 
> Regards,
> Roger
> 

I'm sure it's just a case of pushing all your changes to the remote git repo 
so I'll wait for those changes. :)

-- 
Regards,
Andres