[buildd-tools-devel] Bug#551311: Bug#551311: Updated patches for debuild like functionality in sbuild.

[Roger Leigh]

On Thu, Nov 12, 2009 at 11:30:18PM -0500, Andres Mejia wrote:
> On Tuesday 27 October 2009 01:22:14 Andres Mejia wrote:
> > On Friday 23 October 2009 19:23:59 Andres Mejia wrote:
> > > Here are a new set of patches for some debuild like functionality
> > >  implemented directly in sbuild. Details of what's new is in the patch
> > > for the man page but in short, sbuild would now be able to build from a
> > > Debianized source package, run lintian after a build, and run external
> > > commands before and after a build.
> > >
> > > With this, the sbuild-debuild script and manpage can be removed.
> > 
> > Something I forgot to include was cleaning the source directory before
> > building the source packages. Here's a patch that fixes that.
> > 
> 
> Were these patches reviewed? No rush, just wondering.

Not yet, I'm afraid.  I plan to catch up on pending sbuild patches this
weekend, and hopefully I'll have time for these as well.

> With these patches, it would be possible to run lintian on a package after it 
> has been built, but only when sbuild is passed the --run-lintian option. Also, 
> currently, even if a lintian run would fail (due to a package raising some 
> lintian error), sbuild (correctly) reports that the package has been built 
> successfully.

That sounds fine.

> I was wondering if instead, sbuild should run lintian by default and change 
> the corresponding option from --run-lintian to --no-lintian. Also, I was 
> wondering if sbuild should be changed in some way where sbuild reports a 
> failure in case a lintian run failed.

I haven't checked the patch yet, but if you have a corresponding
configuration variable in sbuild.conf, users can just set the default
there and you can either have paired --lintian/--no-lintian or have
--lintian=yes|no|true|false.

For reporting error on failure, I would have this disabled by default
and settable only in sbuild.conf.

> With this, I was also wondering if sbuild should support running piuparts in 
> the same way as it would support running lintian.

That would also be very nice to have.  It may be more appropriate to
have a general mechanism to run checks after a build, such as a
/etc/sbuild/post-build.d which can have scripts to run on the built
package (just run with run-parts).  This code can be idential to the
lintian support, but just generalised.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20091114/2c9da9a3/attachment.pgp>