[buildd-tools-devel] Bug#576407: buildd: It would be nice if NSSDATABASES allowed comments

[Santiago Vila]

Package: buildd
Version: 0.60.0
Severity: wishlist

There is a subtle incompatibility between buildd and schroot.

schroot ships a file called /etc/schroot/default/nssdatabases
like this:

# System databases to copy into the chroot from the host system.
#
# <database name>
passwd
shadow
[...]

buildd, in turn, puts a file called 25nssdatabases in /etc/schroot/setup.d
which does this:

            while read db; do
                dup_nss "$db" "${CHROOT_PATH}/etc/$db"
            done < "$NSSDATABASES"

which makes schroot to fail when "fb" is one of the commented lines.

I first fixed this in my system in this way:

            grep -v ^# "$NSSDATABASES" | while read db; do
                dup_nss "$db" "${CHROOT_PATH}/etc/$db"
            done

Then I realized that this was already fixed in schroot in 20nssdatabases:

            while read db; do
                if echo "$db" | egrep -q '^(#|$)' ; then
                    continue
                fi
                dup_nss "$db" "${CHROOT_PATH}/etc/$db"
            done < "$NSSDATABASES"

Since there is at least one program which uses comments for the
NSSDATABASES file, it would be nice if all of them supported comments.

Thanks.