[buildd-tools-devel] Bug#599350: Bug#599350: Bug#599350: user in primary group "sbuild" cannot run sbuild

[Roger Leigh]

tags 599350 + fixed-upstream pending
thanks

On Wed, Oct 06, 2010 at 11:29:41PM +0100, Roger Leigh wrote:
> On Wed, Oct 06, 2010 at 09:56:24PM +0200, Jakub Wilk wrote:
> > Package: sbuild
> > Version: 0.60.0-2
> > Severity: minor
> > 
> > Is "sbuild" is a primary group of a user (but not auxillary), he
> > cannot run sbuild:
> > 
> > $ id
> > uid=107(sbuild) gid=107(sbuild) groups=107(sbuild)
> > 
> > $ sbuild
> > User sbuild is not a member of group sbuild in the system group database
> > See "User Setup" in sbuild-setup(7)
> 
> This is due to using the POSIX function getgrnam(3) to get the
> complete group list of sbuild users.  The output of
> "getent group sbuild" will also do the same.  Since the sbuild
> user has the sbuild group as their primary group in the passwd
> file, this doesn't show up.
> 
> We could update the check to look at both group and passwd.
> However, now that sbuild uses schroot for everything, the group
> membership isn't actually required for anything particularly
> special (summary stats under /var/lib/sbuild, which are not very
> useful).  We could equally just drop the check and the summary
> stats.

Fixed in git.  We were already doing the check, but failing
previously if the user wasn't in the group database for the
sbuild group.  I removed that check so it now just looks at
gid and supplementary groups.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20101101/7867fc9b/attachment.pgp>