[buildd-tools-devel] [PATCH] buildd: Get detailed build status and stats from sbuild

[Roger Leigh]

On Sat, Nov 13, 2010 at 04:16:54PM +0100, Philipp Kern wrote:
> Hi there,
> 
> On Sat, Nov 13, 2010 at 03:01:24PM +0000, Roger Leigh wrote:
> > I've attached a proof of concept patch to pass back detailed
> > information about a build to buildd from sbuild.  At the end of a
> > build, sbuild prints RFC-822-style text to stdout detailing
> > build state, failure cause (if any), and information about the
> > package, statistics about the build etc.
> 
> Why don't we still exit with the exit code?
> 
> The RFC822-style interface is a nice idea that could just be placed
> on top of the current mechanism.  And I fully agree that the build
> meta information should be passed through a RFC822 interface.
> (Although we currently take that information from the mailed
> build logs anyway, the stuff you changed is only summarized and
> mailed to the buildd admin periodically.  The syntax within the mailed
> build logs *must* stay the same, though.)

I've attached a new version of the patch to address some of the issues
brought up.  Applies to master and/or buildd-merge2 branches.

- I've removed the delimiters
- sbuild now outputs a separate RFC-822 block for each job queued
- sbuild continues to report the exit status for failed jobs, but
  this is only meaningful for the last job queued; when multiple
  jobs are queued, the value is meaningless
- buildd parses and stores all received blocks
- buildd only makes use of the block for the current job, since
  buildd is not currently queuing multiple jobs with sbuild
  (to be honest, I'm unconvinced the is the responsibility of sbuild
  at all--this is after all what buildd is intended for)
- added logging of the failure stage when the job was unsuccessful

Again, untested in real world use.  The behaviour is intended to be
unchanged from the existing buildd code though--it's just using the
passed back data rather than the exit status to determine the job
state.


Regards,
Roger
-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildd-stats-copying2.patch
Type: text/x-diff
Size: 8365 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20101114/177f932b/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20101114/177f932b/attachment.pgp>