[buildd-tools-devel] Bug#583337: reassign to dpkg-dev with request to support -sn for all formats?

Yaroslav Halchenko yoh at debian.org
Thu Oct 14 00:33:51 UTC 2010


On Wed, 13 Oct 2010, Raphael Hertzog wrote:
> I really don't see why this sbuild bug should be reassigned to dpkg-dev.

let's see together ;)

> I think you are misunderstanding "-sn". It does not (and never did AFAIK)
> extract only the packaging files.

you are 100% correct and I misunderstood its meaning - thank you for the
clarification!  That allows me to refactor this bugreport into 2 ;)

> (which is now assured by the --no-copy option common to all formats)

so, for the sake of clarity and since now there is more than 1 format,
'-sn' should be slowly deprecated and meanwhile aliased to --no-copy thus could
have the same effect for all formats...  Especially since it is ALREADY causing
EXACTLY the same action as far as I see:

$> grep -A 1 -e '\^--no-copy' dpkg-source.pl 
    } elsif (m/^--no-copy$/) {
        $options{'copy_orig_tarballs'} = 0;
$> grep -e '-sn' ./Dpkg/Source/Package/V1.pm
        $o->{'copy_orig_tarballs'} = 0 if $1 eq 'n'; # Extract option -sn

or in other words -- there seems to be no reason for -sn to be format-specific.
That is imho at least a wishlist-grade Bug#1 addressing #583337 to full extent
of the original "problem".

> extract only the packaging files.

and, that would be a pure wishlist-grade Bug#2, I guess.

From what I see reprepro uses -sn to run extract only to
cherry-pick debian/{copyright,control} files and extraction of the
packaging alone seems to be a logical step to save resources.

So, it could be '--packaging-only', or '--debian-only' argument with
format-specific handling... For '--packaging-only' for V1 it could be as
ugly as  something mimicking

patch -r /dev/null -p1 --no-backup-if-mismatch -E

but since there is a complete mighty ./scripts/Dpkg/Source/Patch.pm, I guess,
it could be done cleaner with simple filtering of the diff for the context of
debian/.  For V3 quilt and native implementations are really banal. For
V3 git/bzr/... -- would depend I guess, but those are 'experimental' anyways ;-)

Do you think those two wishlists are valid?

-- 
                                  .-.
=------------------------------   /v\  ----------------------------=
Keep in touch                    // \\     (yoh@|www.)onerussian.com
Yaroslav Halchenko              /(   )\               ICQ#: 60653192
                   Linux User    ^^-^^    [175555]







More information about the Buildd-tools-devel mailing list