[buildd-tools-devel] Bug#571806: Bug#571806: Bug#571806: sbuild: STDERR not being piped in Sbuild::Build::run_apt

[Roger Leigh]

tags 571806 + fixed-upstream pending
thanks

On Sun, Oct 31, 2010 at 12:06:35PM +0000, Roger Leigh wrote:
> On Sun, Feb 28, 2010 at 02:38:22AM -0500, Andres Mejia wrote:
> > Package: sbuild
> > Version: 0.60.0-1
> > Severity: normal
> > 
> > It looks as though STDERR is not being properly piped in the run_apt()
> > subroutine. This problem may be in Sbuild::Chroot, but I haven't thouroughly
> > checked. This is from sbuild version 0.60.0-1 with the patch in bug #403246.
> > 
> > Here's a debug output. Note the 'E: Couldn't find package' message and how
> > it's missing in $msgs at the end.
> 
> STDERR is probably going directly to the build log since we aren't
> intercepting it.  We should either redirect it to the same pipe as
> stdout so we can process it in one go, or drop the checking entirely,
> since it's not exactly reliable in any case since it depends upon
> the apt messages never changing.  The same applies to the broken
> build environment: if it's broken we fail and it's already logged
> in the package build log, so I'm not sure what we gain from the
> extra complexity.
> 
> The virtual packages/ALTERNATIVES handling is a little different.
> However, this is really the wrong place to handle it: rather than
> retrying, the dependency resolver should have already handled this.
> Note it's also using the hardcoded ALTERNATIVES list, rather than
> any genuine package-provided alternatives, so IMO it's also
> broken and we could possibly remove it.

OK, we've opted to remove this code, which fixes the bug as a side-
effect since stderr is no longer needed.  The ALTERNATIVES support
is also removed, since the aptitude resolver does this properly.

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20101031/e797705e/attachment-0001.pgp>