[buildd-tools-devel] Bug#619416: Bug#619416: sbuild.conf changes on every rebuild

[Roger Leigh]

tags 619416 + patch fixed-upstream pending
thanks

On Wed, Mar 23, 2011 at 07:01:26PM +0100, Jakub Wilk wrote:
> I rebuilt sbuild twice and I got two different conffiles (diff
> attached). Apparently a session identifier is encoded in the default
> value for $build_dir. Please don't do that; I don't want to be
> prompted by dpkg about modified conffiles unless something vital has
> been changed.

Thanks for finding this.  I thought I had found and special-cased all
varying values in the generated output.

I've applied this patch to make it skip the real (variable) value and
use a fake static one as an example:

index 789e5f1..0d874f0 100644
--- a/lib/Sbuild/Conf.pm
+++ b/lib/Sbuild/Conf.pm
@@ -564,6 +564,8 @@ sub setup ($) {
            VARNAME => 'build_dir',
            GROUP => 'Core options',
            DEFAULT => cwd(),
+           IGNORE_DEFAULT => 1, # Don't dump class to config
+           EXAMPLE => '$build_dir = \'/home/pete/build\';',
            CHECK => $validate_directory,
            HELP => 'This option is deprecated.  Directory for chroot symlinks a
        },


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20110323/e2c6e29f/attachment-0001.pgp>