[buildd-tools-devel] Bug#645223: Bug#645223: Bug#645223: schroot: 15killprocs has a race condition when killing processes

[Roger Leigh]

tags 645223 + fixed-upstream pending
thanks

On Sun, Oct 16, 2011 at 03:35:43PM +0100, Roger Leigh wrote:
> On Thu, Oct 13, 2011 at 06:40:56PM +0200, Patrick Ohly wrote:
> > Invoking /bin/kill on processes fails if the process already
> > quit by itself while the schroot shutdown runs. Because of "set -e"
> > this causes the whole shutdown to fail.
> > 
> > I have seen this occasionally in a nightly testing setup involving
> > a D-Bus session: when the D-Bus daemon stops, all other processes
> > depending on it also shut down automatically, with or without being
> > killed.
> > 
> > Attached a patch which wraps kill in a function which merely logs
> > the problem instead of aborting.
> 
> Many thanks for the patch, it looks good.  I'll test and apply it
> shortly.

Applied to git on the master and schroot-1.4 branches.  This will be
included in the next stable upload soon.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.