[buildd-tools-devel] Bug#626361: Bug#626361: Bug#626361: run lintian and piuparts from within the chroot

Reinhard Tartler siretart at tauware.de
Tue Feb 21 22:12:18 UTC 2012


On Fr, Jan 06, 2012 at 21:23:18 (CET), Reinhard Tartler wrote:

> Please review the following patch. It seems to me much more sensible to
> run lintian in the chroot than running lintian on the host for the
> mentioned reasons above. For the sake of simplicity and to avoid
> confusion on the user side, I've decided against making the choice
> between "use host lintian" or "install lintian in the chroot"
> configurable. With this, the patch turned out to be quite short:
>
> === modified file 'lib/Sbuild/Build.pm'
> --- lib/Sbuild/Build.pm	2011-08-18 09:22:10 +0000
> +++ lib/Sbuild/Build.pm	2012-01-06 20:22:17 +0000
> @@ -1127,12 +1127,17 @@
>  
>      $self->log_subsubsection("lintian");
>  
> +    my $resolver = $self->get('Dependency Resolver');
>      my $lintian = $self->get_conf('LINTIAN');
>      my @lintian_command = ($lintian);
>      push @lintian_command, @{$self->get_conf('LINTIAN_OPTIONS')} if
>          ($self->get_conf('LINTIAN_OPTIONS'));
>      push @lintian_command, $self->get('Changes File');
> -    $self->get('Host')->run_command(
> +
> +    $resolver->add_dependencies('LINTIAN', 'lintian');
> +    return 1 unless $resolver->install_deps('lintian', 'LINTIAN');
> +
> +    $self->get('Session')->run_command(
>          { COMMAND => \@lintian_command,
>            PRIORITY => 0,

ping?

what do you think about this patch?

I've been using it successfully for all my upload this year. It allows
me to always use the most up-to-date and correct version of lintian
dependening on the chroot (sid, squeeze-backports, precise, etc.)

Cheers,
Reinhard


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4





More information about the Buildd-tools-devel mailing list