[buildd-tools-devel] Bug#672113: schroot: 15killprocs does not check the right directory

[Julien Viard de Galbert]

Package: schroot
Version: 1.4.25-1+b1
Severity: normal
Tags: patch

Dear Maintainer,

While using sbuild with a file schroot configuration I noticed that
sometimes the session would not close. It appeared that some daemon
was still running and keeping the filesystem busy.

I'm using a tar with a toplevel directory containing the actual chroot
content. My configuration looks like that:
....
type=file
file=/path/to/file.tar
location=/squeeze

Adding some debugging to 15killprocs I noticed that it misses the 
location part. So I tried the following change and it seams to fix it
for me.

diff --git a/etc/setup.d/15killprocs b/etc/setup.d/15killprocs
index 3b679f5..7927ee7 100755
--- a/etc/setup.d/15killprocs
+++ b/etc/setup.d/15killprocs
@@ -84,5 +84,5 @@ do_kill_all()
 }
 
 if [ $STAGE = "setup-recover" ] || [ $STAGE = "setup-stop" ]; then
-    do_kill_all "$CHROOT_MOUNT_LOCATION"
+    do_kill_all "$CHROOT_PATH"
 fi


Please double check that the change is correct and consider including it
in a later release.

Best Regards,

Julien VdG

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages schroot depends on:
ii  libboost-filesystem1.49.0       1.49.0-3
ii  libboost-program-options1.49.0  1.49.0-3
ii  libboost-regex1.49.0            1.49.0-3
ii  libboost-system1.49.0           1.49.0-3
ii  libc6                           2.13-32
ii  libgcc1                         1:4.7.0-7
ii  liblockdev1                     1.0.3-1.4+b2
ii  libpam0g                        1.1.3-7.1
ii  libstdc++6                      4.7.0-7
ii  libuuid1                        2.20.1-4
ii  schroot-common                  1.4.25-1

schroot recommends no packages.

Versions of packages schroot suggests:
pn  aufs-modules | unionfs-modules  <none>
pn  btrfs-tools                     <none>
pn  debootstrap                     1.0.40
pn  lvm2                            <none>

-- no debconf information