[buildd-tools-devel] Bug#477937: Bug#477937: [Buildd-tools-devel] Bug#477937: Bug#477937: Bug#477937: double check for repo type

[Roger Leigh]

tags 477937 + pending fixed-upstream
thanks

On Wed, May 09, 2012 at 12:13:02AM +0100, Roger Leigh wrote:
> On Wed, Apr 30, 2008 at 02:54:33PM +0100, Roger Leigh wrote:
> > On Wed, Apr 30, 2008 at 11:57:49AM +0400, martin f krafft wrote:
> > > also sprach Roger Leigh <rleigh at whinlatter.ukfsn.org> [2008.04.29.1922 +0400]:
> > > > This is still a little hacky.
> > > 
> > > Less so than my approach¸ anyway.
> > > 
> > > > This is where writing the chroot_git class would make things
> > > > a little nicer--it would allow customisation directly in
> > > > schroot.conf with extra keys, and set them up in the environment
> > > > for the setup scripts to use.
> > > 
> > > All I am saying is that why make this specific to git? Why can't
> > > file and git and whatever else might be created not be handled by
> > > chroot_custom, which is instantiated when no better chroot type
> > > handler exists. It sets $CHROOT_TYPE according to what type=
> > > parameter says and populates the environment with any additional
> > > parameters in schroot.conf. Now it's up to 05file, 05git, 05whatever
> > > to set up the chroot. If I wanted to add 05hg or 05bzr, I could,
> > > without any hacks or C++ hackery.
> > 
> > Ah, I see where you are coming from.  This would be quite possible to
> > do.  The configuration would be somewhat harder to validate than what is
> > currently allowed (we would probably just s/[a-z]/[A-Z]/ and s/-/_/ to
> > upcase and convert - to _.  The names would have to be valid shell
> > variables.
> > 
> > I'll certainly look at adding this--it shouldn't be too much work.
> 
> The next part is to create the chroot_custom class as above.

Completed and on git master.  This will be in the 1.5.2 upload to
experimental later this week, following some testing of the
release as a whole (the custom type is now fully functional).

It's taken four years to get to this point (PhDs do get in the way
of hacking!) but hopefully you'll find it useful, and I'm sure it
will be useful for others.  If you're still interested in a git
chroot type, this will be one way of experimenting with it
without the need to write any C++ code while prototyping the
concept.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800