[buildd-tools-devel] Bug#672113: Bug#672113: schroot: 15killprocs does not check the right directory

[Roger Leigh]

tags 672113 + pending
thanks

On Tue, May 15, 2012 at 01:15:49AM +0200, Julien Viard de Galbert wrote:
> > In this case CHROOT_MOUNT_LOCATION is actually better, since it not
> > only /includes/ CHROOT_PATH in the checks, it also will kill processes
> > which are outside the chroot but which would cause the umount to
> > fail (not for file, but certainly for lvm-snapshot and other related
> > types).
> > 
> This is where I disagree :)
> 
> I would agree if the "do_kill_all" function was doing some call to
> "lsof" as I had to do to find out the offending process, but this
> function is not doing that. Instead it compares the entry in
> "/proc/PID/root/" with its parameter to find process that are run
> from within the chroot. So that's why I think the parameter should be
> the actual chroot path so CHROOT_PATH.

Ah, in this case your assessment is entirely correct.  Committed into
git and will be in the next upload.  This should hopefully be
tomorrow, to experimental, pending fixing one last build issue.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800