[buildd-tools-devel] Bug#691539: Bug#691539: sbuild: Does arch wildcard check outside build chroot not inside, which is wrong when new architectures are added

[Roger Leigh]

On Fri, Oct 26, 2012 at 05:13:10PM +0100, Wookey wrote:
> If a new architecture is added to dpkg such that the version inside
> the build chroot knows about this, but the version outside does not
> then the Arch check stage can fail if the package arch is a wildcard
> like 'linux-any'.
> 
> The offending code is in lib/Sbuild/Build.pm:
> 
> That arch check should (I think) be done inside the chroot, where it
> will come out correct. 

This makes sense I think.  The only possible disadvantage is the
performance hit of setting up the schroot session and then tearing it
down immediately if invalid.  But that's not too a high cost, and
correctness is better.

I'll just need to check where this occurs in the build sequence and
maybe move it to a point where we have an active session, if it's
not already in the right place.  I'll need to double-check that has
no nasty side-effects as well.

Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800