[buildd-tools-devel] Bug#722012: Bug#722012: Sbuild::Conf: missing use File::Spec

[Roger Leigh]

On Sat, Sep 07, 2013 at 12:12:50AM +0200, Vaclav Ovsik wrote:
> I just played with sbuild and I got this:
> 
> bobek:~# sbuild-adduser zito
> Error reading configuration: Can't locate object method "catfile" via package "File::Spec" at /usr/share/perl5/Sbuild/Conf.pm line 71.
> 
> There is simply missing package usage statement, so I fixed this by:
> 
> --- /usr/share/perl5/Sbuild/Conf.pm~	2013-09-06 23:54:45.608414498 +0200
> +++ /usr/share/perl5/Sbuild/Conf.pm	2013-09-06 23:55:08.656413817 +0200
> @@ -25,6 +25,7 @@
>  use warnings;
>  
>  use Cwd qw(cwd);
> +use File::Spec;
>  use POSIX qw(getgroups getgid);
>  use Sbuild qw(isin);
>  use Sbuild::ConfBase;

Thanks for the patch.

> sbuild-adduser works now I hope...

Does this fix work for you?  Seems fine here with a cursory test.

Since the File::Spec->catfile is a class method call, I don't think that
the "use File::Spec" is necessary here, or at the very least wasn't
necessary previously.  I'm wondering if this is broken due to the recent
Perl 5.18 transition since it was working fine before that.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20130908/86168d17/attachment.sig>