[buildd-tools-devel] Bug#771235: [PATCH] sbuild: Fails to build a few valid packages that are arch all plus others

[Lennart Sorensen]

Source: sbuild
Version: 0.65.0-1
Severity: normal

Dear Maintainer,

I was trying to do a rebuild of some of the packages in jessie, and
sbuild refuses to try building hsqldb1.8.0 which is a bit odd (but valid)
in that the architecture field is:
Architecture: all kfreebsd-i386 kfreebsd-amd64

Unfortunately sbuild incorrectly refuses to build this package even when
told it should build architecture all packages.

It is simple to fix:

--- /usr/share/perl5/Sbuild/Build.pm.ori	2014-11-27 14:51:57.632255374 -0500
+++ /usr/share/perl5/Sbuild/Build.pm	2014-11-27 14:52:14.255903901 -0500
@@ -1037,7 +1037,7 @@
 	    }
 	}
 	if ($dscarchs ne "any" && !($valid_arch) &&
-	    !($dscarchs eq "all" && $self->get_conf('BUILD_ARCH_ALL')) )  {
+	    !($dscarchs =~ /\ball\b/ && $self->get_conf('BUILD_ARCH_ALL')) )  {
 	    my $msg = "$dsc: $host_arch not in arch list or does not match any arch wildcards: $dscarchs -- skipping\n";
 	    $self->log($msg);
 	    Sbuild::Exception::Build->throw(error => "$dsc: $host_arch not in arch list or does not match any arch wildcards: $dscarchs -- skipping",

After all, if we are building architecture all packages and all is in
the list of architectures, then we should continue.  The list does not
have to contain only all.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (I was running the chroot on top of wheezy, but I doubt the kernel would cause the errors above)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash