[buildd-tools-devel] Suggesting RFH bug for sbuild

[Wookey]

+++ Wookey [2014-09-23 18:06 +0100]:
> +++ Wookey [2014-09-20 01:11 +0100]:
> > +++ Bálint Réczey [2014-09-01 17:34 +0200]:
> > > 2014-09-01 0:07 GMT+02:00 Geoffrey Thomas <geofft at ldpreload.com>:
> > > >
> > > the motivation for
> > > writing my previous email was finding people who would be interested
> > > in regular contribution to the package, because I alone can't make a
> > > real difference here IMO. 
> 
> Answering myself...

And again
  
> > I'm currently very interested in having #608840 (Setup-commands run as
> > root),

> > I note that 760991 also adds more hook commands and is trivial apart
> > from deciding on what best names are so I propose to merge that with
> > 608840/607228.
> > 
> > Or alternatively just run --chroot-setup-commands as root, in line
> > with the other setup/cleanup command, and thus have no command run as
> > user instead of root? I still don't know what the use-case is for the
> > run-as-sbuild-user setup command.
> 
> I'd really like to know if there is a good reason for keeping the
> non-root commands around.

A bit more peering at these two bugs, the code and the docs suddenly
made it clear that in fact the run-as-user --chroot-setup-commands and
the new --pre-realbuild-commands hook from 760991 are in fact exactly
the same thing. So that's a good reason for having it, and now I'm back 
(after some renaming) to a nice symmetrical set of 3 pairs of hooks:

--pre-build-commands       root  external   After chroot session setup
--chroot-setup-commands    root  in chroot  After chroot initialisation, before 'update'
--starting-build-commands  user  in chroot  After update and dependency-install, before build
--finished-build-commands  user  in chroot  After build, when timer stops, before cleanup
--chroot-cleanup-commands  root  in chroot  After build, before session is closed
--post-build-commands      root  external   After session is shut down

Interestingly, it was writing the docs that finally made this clear to me 
- so there is a good reason to write docs :-)

Wookey
-- 
Principal hats:  Linaro, Emdebian, Wookware, Balloonboard, ARM
http://wookware.org/