[buildd-tools-devel] Bug#655215: Bug#655215: Bug#655215: sbuild: Do not do run "fakeroot ./debian/rules clean" before building source

[Johannes Schauer]

Hi,

On Mon, 31 Aug 2015 18:43:36 +0200 Tzafrir Cohen <tzafrir at cohens.org.il> wrote:
> Long ago, on Mon, Jan 09, 2012 at 01:35:09PM +0000, Roger Leigh wrote:
> > In this situation, I guess there are two possibilities:
> > 
> > 1) You run "dpkg-source -b" yourself, then run sbuild with the
> >    resulting .dsc.  This won't require any changes to sbuild directly.
> > 
> > 2) We add an option to sbuild to permit cleaning of the tree to be
> >    skipped.  I guess we can add -nc like for dpkg-buildpackage.
> > 
> > It depends on whether (1) is too much of an inconvenience.  But it's
> > certainly possible to do (2).
> 
> (1) is indeed of indeed of inconvenience for me. Attached a simple
> patch for (2).

thanks for the patch!

I did not try it out yet but have two comments:

 1. Your if statement in bin/sbuild only wraps the system() call but not the
    check whether system() was successful

 2. You are adding two new command line options but did not update the man
    page.

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20150913/5c3a3c37/attachment.sig>