[buildd-tools-devel] Bug#834497: sbuild: apt, aspcud, xapt resolvers dropping extra repositories before using them

[Maximiliano Curia]

Package: sbuild
Version: 0.70.0-1
Severity: important
Tags: patch

Hi,

The current version of sbuild is cleaning up the extra repositories before 
using them. This was introduced by 0e71b40, adding extra repositories unlink 
to cleanup_apt_archive, which is called at the end of the resolvers 
install_deps', which in turn is called by install_core_deps and install_main_deps.

Since a normal build has a install_core_deps call before the 
install_main_deps, the extra repositories are missing for the main part.

The aptitude resolver is not affected as it's not calling the 
cleanup_apt_archive (I'm assuming that this relays on Build calling cleanup at 
the right moments), the attached patch removes the cleanup_apt_archive 
invocation from the resolvers assuming that the aptitude approach is correct.

Happy hacking,

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 'testing'), (500, 'stable'), (50, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armhf

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages sbuild depends on:
ii  adduser         3.115
ii  apt-utils       1.3~pre2
ii  libsbuild-perl  0.70.0-1
pn  perl:any        <none>

Versions of packages sbuild recommends:
ii  debootstrap  1.0.81
ii  fakeroot     1.21-1

Versions of packages sbuild suggests:
ii  deborphan  1.7.28.8-0.3
ii  wget       1.18-2

-- Configuration Files:
/etc/sbuild/sbuild.conf changed [not included]

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Avoid-dropping-extra-repositories-before-using-them.patch
Type: text/x-diff
Size: 1522 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20160816/9447475f/attachment.patch>