[buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

[Samuel Thibault]

Package: libsbuild-perl
Version: 0.71.0-2
Severity: important

Hello,

I tried to upgrade to the latest version of sbuild, but builds fail with

“
W: Stripped single quote from command for security: use strict;
use warnings;

...
close $releasefh;

Scalar found where operator expected at -e line 21, near "&, $packages"
        (Missing operator before  $packages?)
Scalar found where operator expected at -e line 25, near "&, $saved_stdout"
        (Missing operator before  $saved_stdout?)
”

i.e. the perl script gets broken because ChrootPlain's and ChrootSudo's
get_command_internal drop single quotes from the command before running
it.

I just replaced all single quotes (') into double quotes (") in the
embedded script between SCRIPTEND markers, and now it works fine.

Samuel

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.7.0 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)