[buildd-tools-devel] Bug#836175: Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

[Johannes Schauer]

Hi,

Quoting Samuel Thibault (2016-08-31 19:33:27)
> Johannes Schauer, on Wed 31 Aug 2016 19:29:47 +0200, wrote:
> > Did you not create your chroot with sbuild-createchroot?
> 
> I use /usr/share/sbuild/create-chroot, which does not seem to use
> sbuild-createchroot

how did you find that script? In contrast to sbuild-createchroot it is not even
in $PATH. Also the sbuild man page refers to sbuild-createchroot and not the
create-chroot script. I was not aware that anybody was using it.

I only recently (one year ago) took over sbuild maintenance and lots of bits
only seem to be of historic interest to me. But I didn't remove them yet
because I don't know if somebody still relies on them.

It seems to be doing a very similar job to sbuild-createchroot. For example it
seems to also set up schroot. Have a look into your /etc/schroot/chroot.d/.

> > It is not unlikely that the support for sudo-type chroots in sbuild is
> > broken.  I don't think anybody is using those anymore. If it turns out that
> > you are still for some reason using the sudo backend, then I would like to
> > help you investigate how to best fix it.
> 
> Well, with the proposed patch it works just fine :)

It will. But the question is: is it the right fix for the problem?

An alternative solution would be to remove the single quote handling from
lib/Sbuild/ChrootPlain.pm and lib/Sbuild/ChrootSudo.pm.

Thanks!

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20160831/3fd6da3e/attachment.sig>