[buildd-tools-devel] Bug#842281: sbuild: --extra-repository cannot be used with --no-apt-update

[Johannes Schauer]

Control: tag -1 + pending

Hi Ilias,

On Sun, 20 Nov 2016 18:37:12 +0200 Ilias Tsitsimpis <i.tsitsimpis at gmail.com> wrote:
> On Thu, Nov 10, 2016 at 03:22AM, Johannes Schauer wrote:
> > I would say that this is a feature instead of a bug. Imagine it were the other
> > way round and sbuild would run "apt-get update" even if --no-apt-update was
> > specified, then I would get another bug report "sbuild runs apt-get update even
> > though --no-apt-update was given".
> 
> I believe these are two different things. In my understanding,
> `--no-apt-update' means do not update sbuild's default archive. The
> patch I provided does exactly that. It updates the extra repository, but
> not the default one (this is also what used to happen before).
> 
> > With what justification would you still run "apt-get update" even if
> > --no-apt-update was passed? I would've said that a user who uses
> > --extra-repositories just must not use --no-apt-update. Maybe sbuild should
> > even print a warning if they attempt to do so.
> 
> I believe that there is value in using both `--no-apt-update' and
> `--extra-repositories', especially when the extra repository is a local
> archive. In fact, that is the case with one of the tools used within the
> Debian Haskell Group (pkg-haskell-tools[1]), and the reason I am
> reporting this.
> 
> It seems to me that what is missing here, is a way to tell sbuild to
> not update the default archive, but also use the ones provided with
> `--extra-repositories'. pkg-haskell-tools uses the `--no-apt-update'
> flag to achieve this, but maybe this is not the right way to do this.
> 
> What do you think?

lets look at this from a different angle. If the user uses
--extra-repositories, then there is probably no reason why the user would ever
want sbuild *not* to update from this repository. It thus would make sense to
assume that passing --extra-repositories is an implicit request from the user
to update that repository or otherwise it would not be used - independent from
any other command line option.

I applied attached patch to my local git. If you want, you can make sure that
it fixes your issue.

Thanks!

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Unconditionally-update-repositories-given-via-extra-.patch
Type: text/x-diff
Size: 3583 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20161222/15efabd2/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20161222/15efabd2/attachment.sig>