[buildd-tools-devel] Bug#865541: Bug#865541: sbuild --apt-distupgrade should not remove build-essential

[Raphael Hertzog]

Hi,

On Mon, 26 Jun 2017, Johannes Schauer wrote:
> > It would because actually I pass "--apt-update --apt-upgrade" but not
> > "--apt-distupgrade" and I have no ~/.sbuildrc.
> 
> then why not pass --no-apt-distupgrade?

Because when I wrote that script, I was probably not aware that
--apt-distupgrade was the default.

> > If I call sbuild-update --dist-upgrade, I might understand that you would
> > like the command to fail.
> 
> Unfortunately, currently sbuild makes no distinction between how a
> configuration variable was set, whether it was via the sbuildrc, a commandline
> switch, an environment variable or whether the user changed nothing and it was
> just the default.
> 
> Adding provisions that would let sbuild know who set a variable and then
> letting sbuild behave differently depending on how the variable was set would
> be a big effort.

I understand this. But you can react differently to the failure in the
various places where you are calling "$resolver->distupgrade".

> > For a build chroot, we want the opposite... as long as it doesn't break
> > the build chroot. If the new perl causes the removal of dpkg-dev, then
> > it should not be dist-upgraded. If it causes the removal of
> > liblocale-gettext-perl only, then it's fine.
> 
> Unfortunately, "apt-mark hold" has the nasty side effect that it not only stops
> a package from being removed but it also stops a package from being upgraded.

Hence we start with "apt-get install build-essential" which does upgrade
it before we mark it back on hold.

> > But to me it seems like useless complexity when 99,9% of the users just
> > want the build to succeed with the freshest working build environment that
> > we can get in the current situation.
> 
> Do they? At least I would count myself to the other 0.1% but it's hard to find
> out.

Yeah, I don't plan to run a survey on #debian-devel but that's my
feeling. :)

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/