[Debburn-changes] r746 - cdrkit/trunk/genisoimage

Peter Samuelson peters-guest at alioth.debian.org
Sat Apr 21 09:11:03 UTC 2007


Author: peters-guest
Date: 2007-04-21 09:11:02 +0000 (Sat, 21 Apr 2007)
New Revision: 746

Modified:
   cdrkit/trunk/genisoimage/tree.c
Log:
Followup to r740: Make a global variable static and scope it inside the
block where it is used.

I know this seems like a minor point, but I think random global
variables not only look bad, but are a poor habit to get into
(especially, but not only, for libraries).


Modified: cdrkit/trunk/genisoimage/tree.c
===================================================================
--- cdrkit/trunk/genisoimage/tree.c	2007-04-21 09:04:51 UTC (rev 745)
+++ cdrkit/trunk/genisoimage/tree.c	2007-04-21 09:11:02 UTC (rev 746)
@@ -49,7 +49,6 @@
 #include <schily.h>
 
 extern int allow_limited_size;
-int udf_warned = 0;
 
 #ifdef VMS
 #include <sys/file.h>
@@ -1550,6 +1549,7 @@
 	}
 	/* print a warning but don't spam too much */
 	if (S_ISREG(lstatbuf.st_mode) && (lstatbuf.st_size >= (off_t)0xFFFFFFFF)) {
+		static int udf_warned;
 
 		if( !allow_limited_size || verbose>1)
 			fprintf(stderr, "File %s is larger than 4GiB-1.\n", whole_path);




More information about the Debburn-changes mailing list