[debhelper-devel] Bug#805878: dh-systemd: dh_systemd_start --no-start --restart-after-upgrade causes the service to be started on install

[Michael Biebl]

Am 13.10.2016 um 17:56 schrieb Michael Biebl:
> Am 13.10.2016 um 17:47 schrieb Felipe Sateler:
>> On 13 October 2016 at 12:36, Michael Biebl <biebl at debian.org> wrote:
>>>
>>> Now that compat level 10 has --restart-after-upgrade as default, this
>>> bug has a wider impact (thus bumping the severity).
>>>
>>> With compat level 9 and older, --no-start did not generate any
>>> maintainer scripts code at all.
>>
>> You can get the same with dh 10 with --no-start --no-restart-after-upgrade
> 
> Right. But isn't this an unexpected change?
> See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837528, which is
> related.
> I wonder if --no-start should imply --no-restart-after-upgrade
> 
> If not, we should at least improve the documentation in that regard.


fwiw, in network-manager I use

> override_dh_systemd_start:
>        dh_link lib/systemd/system/NetworkManager.service \
>                lib/systemd/system/network-manager.service
>        dh_systemd_start -pnetwork-manager --no-start NetworkManager-dispatcher.service
>        dh_systemd_start -pnetwork-manager --no-start NetworkManager-wait-online.service
>        dh_systemd_start -pnetwork-manager --restart-after-upgrade NetworkManager.service

After the compat bump to 10, I get the attached diff, which shows many odd issues

postinst/
- NetworkManager-dispatcher.service is restarted 3 times, NetworkManager-wait-online.service 2 times
- we now process NetworkManager.service, although that should be handled by update-rc.d

postrm/,
- systemctl --system daemon-reload has been added 4 times

prerm/
- NetworkManager-dispatcher.service is stopped 3 times, NetworkManager-wait-online.service 2 times

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dh-10.patch
Type: text/x-patch
Size: 7772 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20161013/a9c8dddc/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20161013/a9c8dddc/attachment-0002.sig>