[debhelper-devel] Bug#889006: Bug#889006: dh-autoreconf is run before patching

[Niels Thykier]

Sven Joachim:
> [ CC'ing dpatch maintainer. ]
> 
> On 2018-02-01 08:56 +0200, Adrian Bunk wrote:
> 
>> [...]
> 
> The dansguardian package uses dpatch:
> 
> ,----
> | %:
> | 	dh $@ --with dpatch,autotools_dev,autoreconf
> `----
> 
> And /usr/share/perl5/Debian/Debhelper/Sequence/dpatch.pm has this line:
> 
> insert_before("dh_auto_configure", "dh_dpatch_patch");
> 
> I think this should be changed to
> 
> insert_before("dh_update_autotools_config", "dh_dpatch_patch");
> 
> as is the case in quilt.pm (since quilt 0.63-8.2).  Haven't tested it,
> though.
> 
> Cheers,
>        Sven
> 

Hi Sven,

Thanks for forwarding the issue to dpatch.

Indeed, from my PoV we would ideally fix this issue in dpatch.  However,
we need to handle backports as well and that puts quilt back the table
as well.  I am not quite sure that I want to backport quilt and dpatch
to provide further debhelper backports.

Thanks,
~Niels