[debhelper-devel] Bug#889006: dh-autoreconf is run before patching

[Niels Thykier]

Sven Joachim:
> On 2018-02-02 06:55 +0200, Adrian Bunk wrote:
> 
>> On Thu, Feb 01, 2018 at 07:01:00PM +0000, Niels Thykier wrote:
>>> ...
>>> Indeed, from my PoV we would ideally fix this issue in dpatch.  However,
>>> we need to handle backports as well and that puts quilt back the table
>>> as well.  I am not quite sure that I want to backport quilt and dpatch
>>> to provide further debhelper backports.
>>
>> Why not?
>>
>> dpatch is a mostly obsolete Debian native package,
>> most recent upload 2015.
> 
> Moreover, dansguardian seems to be the only package which actually uses
> dh with the dpatch addon.  Apparently all other packages stuck with
> dpatch still use classic debhelper and not dh.
> 

If we are down to that level, then fixing dpatch in sid and moving on is
probably sufficient (among other, because dansguardian does not have a
history of being backported).

@Gergely: Are you ok with a (possible 0-day) NMU for tweaking the dpatch
sequence?  I am happy to test and include the proposed the patch for
#868978 as well while I am doing the upload. :)

>> quilt still has some upstream development, but nothing big.
>>
>> It might still be easier to revert the change in dh-autoreconf,
>> but dpatch and quilt are not packages where I would see any
>> potential problems with making and supporting a backport.
> 
> Fortunately there is already a backport of quilt for stretch, and adding
> a "Breaks: quilt (<< 0.63-8.2~)" to debhelper or dh-autoreconf looks
> reasonable to me.
> 
> Cheers,
>        Sven
> 

Indeed, there is now a quilt backport with can solve that part with a
Breaks. :)

Thanks,
~Niels