[debhelper-devel] Bug#890373: debhelper: Please fix indendation in postinst-systemd-restart

[Niels Thykier]

Control: tags -1 moreinfo

On Wed, 14 Feb 2018 08:32:31 +0100 Christoph Biedl
<debian.axhn at manchmal.in-ulm.de> wrote:
> Package: debhelper
> Version: 11.1.4
> Severity: minor
> 
> Dear Maintainer,
> 
> while checking the debhelper sniplets created by dh_systemd_* I got
> quite confused by the indentation, making me believe it's some
> malformatted or even invalid shell script.
> 
> Please apply the attached (as it contains tab characters) diff when
> convenient.
> 
> Regards,
> 
>         Christoph

Hi,

The patch does not apply cleanly to 11.1.4 and nor does the problem
appear to be present in 11.1.4:

"""
$ cat -vT autoscripts/postinst-systemd-restart
if [ "$1" = "configure" ] || [...] ; then
^Iif [ -d /run/systemd/system ]; then
^I^Isystemctl --system daemon-reload >/dev/null || true
^I^Iif [ -n "$2" ]; then
^I^I^I_dh_action=restart
^I^Ielse
^I^I^I_dh_action=start
^I^Ifi
^I^Ideb-systemd-invoke $_dh_action #UNITFILES# >/dev/null || true
^Ifi
fi
"""

AFAICT from that output, the file is correctly indented in 11.1.4.

Thanks,
~Niels