[Debian-arabic-packages] SVN Package Addition: jalali-calendar

[Mohammed Sameer]

On Thu, Mar 22, 2007 at 10:59:30AM +0350, Alan Baghumian wrote:
> Hi,
> 
> A new package has been added to the svn.
> 
> Description: Jalali calendar applet for the GNOME desktop
> 
> URL : http://code.google.com/p/jalali-calendar/
> 
> License: GPL
> 
> Package: http://www.parsix.org/packages/pool/main/j/jalali-calendar/
> 
> ITP: #415663
> 
> Please take a look.

Hi,

I'm not into python or python packaging but I have a few points:

* Are you sure you need to depend on  python-gtk2 (>= 2.10.0) python-glade2 (>= 2.10.0) ?
  These are available only in experimental. I passed -d to dpkg-buildpackage and it was built fine.
* You've modified the Makefile, calendar.py, holiday.py and utility.py
  I guess you should create patches and apply them during the "build" time ?
* The .orig.tar md5sum isn't the same as the upstream .tar (Probably because of the modifications above).
* Did you inspect the contents of the resulting deb ( dpkg -c jalali-calendar_1.6-1_i386.deb) ? ;-)

That's all I guess!

-- 
GNU/Linux registered user #224950
Proud Egyptian GNU/Linux User Group <www.eglug.org> Member.
Life powered by Debian, Homepage: www.foolab.org
--
Don't send me any attachment in Micro$oft (.DOC, .PPT) format please
Read http://www.gnu.org/philosophy/no-word-attachments.html
Preferable attachments: .PDF, .HTML, .TXT
Thanx for adding this text to Your signature
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/debian-arabic-packages/attachments/20070322/2d9f2929/attachment.pgp