[Debian-ha-maintainers] Bug#530062: Bug#530062: csync2: bashism in /bin/sh script

Simon Horman horms at verge.net.au
Tue Oct 5 23:57:00 UTC 2010


On Tue, Oct 05, 2010 at 06:41:13PM -0500, Jonathan Nieder wrote:
> severity 530062 minor
> tags 530062 + patch
> quit
> 
> Raphael Geissert wrote:
> 
> > Usertags: goal-dash
> [...]
> >> possible bashism in ./usr/share/csync2/csync2_locheck.sh line 31 (should be
> >> read [-r] variable):
> >>	  if read -p "Do you really want to logout? " in &&
> 
> This works fine in dash, but not in ksh derivatives (e.g., ksh93), which
> use -p for something else.  So it is still not policy-compliant for an
> sh script.  In general, read -p should be replaced with printf
> followed by read.
> 
> More to the point, this is a sample .bash_logout file.  Patch follows.

I wasn't aware that using ksh as /bin/sh ws part of goal-dash.
Am I mistaken?





More information about the Debian-ha-maintainers mailing list