[Debian-ha-maintainers] Bug#749441: drbd8: Conflicting return types of function my_parse

[Michael Tautschnig]

Package: drbd8
Version: 2:8.4.4-1
Severity: wishlist
Usertags: goto-cc

[ I'm aware that I owe a reply regarding #700930; I believe it is fixed but will
confirm that once this one gets fixed. ]

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -I../drbd -I../drbd/compat -D_FORTIFY_SOURCE=2 -Wl,-z,relro  -Wl,-z,relro -o drbdadm drbdadm_scanner.o drbdadm_parser.o drbdadm_main.o drbdadm_adjust.o drbdtool_common.o drbdadm_usage_cnt.o drbd_buildtag.o registry.o config_flags.o libgenl.o drbd_nla.o

error: conflicting function declarations "my_parse"
old definition in module drbdadm_parser file drbdadm_parser.c line 2133
void (void)
new definition in module drbdadm_main file drbdadm_main.c line 132
signed int ()
Makefile:86: recipe for target 'drbdadm' failed
make[2]: *** [drbdadm] Error 64

Really, this is just wrong declarations here

http://sources.debian.net/src/drbd8/2:8.4.4-1/user/drbdadm_main.c?hl=132#L132

and here

http://sources.debian.net/src/drbd8/2:8.4.4-1/user/legacy/drbdadm_main.c?hl=120#L120

as the acclaimed but non-existent return value is never used. Fixing these
declarations will ensure that no undefined behaviour arises.

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-ha-maintainers/attachments/20140527/a41f90dd/attachment.sig>