[Debian-ha-maintainers] Bug#804590: Bug#804590: redhat-cluster: build-depends on libcorosync-dev which is no longer built

[Ferenc Wagner]

Christoph Berg <myon at debian.org> writes:

> Re: Ferenc Wagner 2016-01-08 <87lh7z7o5h.fsf at lant.ki.iif.hu>
>
>>> the script works, but the inner make invocation needs to be prevented
>>> from seeing the outer make from debian/rules:
>>>
>>> env -u MAKELEVEL -u MAKEFLAGS -u MFLAGS debian/check_header_deps pacemaker
>> 
>> Good point, though make doesn't interpret MFLAGS itself, so I wouldn't
>> care about it.  MAKELEVEL does not influence a thing either.  But
>
> I didn't test all combinations, but I think I remember from my past
> make experience that one of these has an influence on the display of
> the "make: entering/leaving directory" messages which were ending up
> in the symbols files here. Make sure you test that.

It does, unless -s is used.  I pretty much rewrote the whole thing, you
can check it on GitHub.  But please don't upload just yet, I'd like to
see pacemaker migrating into testing first. :)

>> MAKEFLAGS rellay must be cleared, and probably MAKEFILES as well.  What
>> do you think about moving this into the script as
>> 
>> ... | MAKEFLAGS= MAKEFILES= make -Bsf - >> ... ?
>> 
>> This would make the script more "standalone".
>
> Sure, good idea. (Though to be honest, the current pipe-makefile-on-
> stdin solution looks quite scary. Maybe you could add some comments to
> explain what it's doing.)

I decided to leave MAKEFILES alone after all, but tried to address the
above points.
-- 
Cheers,
Feri.