[Debian-hebrew-package] Bug#583092: Bug#583092: should return None instead of none

Ron Varburg linux-il at hotmail.com
Wed May 26 15:44:25 UTC 2010


1) I am not familiar with swig.  Can't it produce better documentation?

2) none -> None
I didn't mean to simply substitute one string ("none"), by another
 ("None").  I meant to make it behave, and thus have a similar
 code, to hdate_holyday_string:

--- src/hdate_strings.c    2010-05-26 15:29:19.0
00000000 +0300
+++ src/hdate_strings.c 2010-05-26 15:32:33.000000000
 +0300
@@ -343,7 +343,6 @@
        /* FIXME: abbrev of parasha */
        static char *parashaot[2][62] = {
                {
-                N_("none"),
                 N_("Bereshit"),                /* 1 */
                 N_("Noach"),
                 N_("Lech-Lecha"),
@@ -406,7 +405,6 @@
                 N_("Matot-Masei"),
                 N_("Nitzavim-Vayeilech")},
                {
-                N_("none"),
                 N_("Bereshit"),                /* 1 */
                 N_("Noach"),
                 N_("Lech-Lecha"),
@@ -478,9 +476,9 @@
        /* make sure s is 0 or 1 */
        s = s ? 0 : 1;

-       if (parasha>= 0 && parasha <= 61)
+       if (parasha>= 1 && parasha <= 61)
        {
-               return _(parashaot[s][parasha]);
+               return _(parashaot[s][parasha - 1]);
        }

        /* if not a valid parasha return NULL */


 		 	   		  
_________________________________________________________________
Hotmail: שירות דואר אלקטרוני מהימן ועשיר המסופק בחינם.
https://signup.live.com/signup.aspx?id=60969


More information about the Debian-hebrew-package mailing list