[med-svn] [fermi-lite] 01/02: Add missing declaration. Attention: I think I did it wrong to add a static declaration into a header file (see FIXME inside patch)

[Andreas Tille]

This is an automated email from the git hooks/post-receive script.

tille pushed a commit to branch master
in repository fermi-lite.

commit 0574b5f714da1f638359b076eb0e995736515bd0
Author: Andreas Tille <tille at debian.org>
Date:   Fri Feb 3 10:18:30 2017 +0100

    Add missing declaration.  Attention: I think I did it wrong to add a static declaration into a header file (see FIXME inside patch)
---
 debian/patches/bcf_seqlib.patch | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/debian/patches/bcf_seqlib.patch b/debian/patches/bcf_seqlib.patch
index a365fc8..d4b2a5d 100644
--- a/debian/patches/bcf_seqlib.patch
+++ b/debian/patches/bcf_seqlib.patch
@@ -1,4 +1,7 @@
 Description: Try to take over patches from libSeqLib which needs separate bfc.h
+  FIXME: Please check the FIXME at the end.  I think I did things wrong to put a
+         static declaration into header file but I had no better idea to make
+         ec1buf_init known in libSeqLib
 Author: Andreas Tille <tille at debian.org>
 Last-Update: Thu, 02 Feb 2017 10:57:56 +0100
 
@@ -190,7 +193,7 @@ Last-Update: Thu, 02 Feb 2017 10:57:56 +0100
  	return fml_correct_core(opt, 0, n, seq);
 --- /dev/null
 +++ b/bfc.h
-@@ -0,0 +1,153 @@
+@@ -0,0 +1,163 @@
 +#ifndef AC_BFC_H__
 +#define AC_BFC_H__
 +
@@ -343,4 +346,14 @@ Last-Update: Thu, 02 Feb 2017 10:57:56 +0100
 +//void kmer_correct(ec_step_t * es, int mode, bfc_ch_t * ch);
 +void bfc_opt_init(bfc_opt_t *opt);
 +
++/*
++ * FIXME: This leads to
++/usr/include/fml/bfc.h: At global scope:
++/usr/include/fml/bfc.h:153:22: warning: ‘bfc_ec1buf_t* ec1buf_init(const bfc_opt_t*, const bfc_ch_t*)’ used but never defined
++ static bfc_ec1buf_t *ec1buf_init(const bfc_opt_t *opt, const bfc_ch_t *ch);
++                      ^~~~~~~~~~~
++ * warnings - but the declaration is needed in libSeqLib
++ */
++static bfc_ec1buf_t *ec1buf_init(const bfc_opt_t *opt, const bfc_ch_t *ch);
++
 +#endif

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-med/fermi-lite.git