[Debian-med-packaging] Bug#486048: Bug#486048: minc-tools: bashism in /bin/sh script

[Vincent Zweije]

On Mon, Jun 16, 2008 at 11:32:39PM +0900, Charles Plessy wrote:

||  Le Sun, Jun 15, 2008 at 06:53:10PM +0200, Vincent Zweije a écrit :
||  > tag 486048 patch
||  > thanks
||
||  > -   echo "${0}: Error reading file '$infile'\n"
||  > +   echo "${0}: Error reading file '$infile'"
||  > +   echo
||
||  Dear Vincent,
||
||  thank you very much for the patch.
||
||  Givent that bash itself would not turn the \n into a newline (echo would
||  need the -e option for that), I do not know if the extra line introduced
||  by your patch reflects the intended behaviour. Could you check this
||  with Upstream ?

On non-XSI conformant systems, the behaviour is undefined.  On XSI
conformant systems, echo will expand the \n into a newline.  See:

    http://www.opengroup.org/onlinepubs/009695399/utilities/echo.html

Moreover, the message is, in my opinion, an error message intended for
human eyes.  Escape sequences have no place there.

Probably, upstream tests on a system that works like dash, not bash:

    $bash -c 'echo "foo\n"'
    foo\n
    $dash -c 'echo "foo\n"'
    foo

    $

If all this doesn't convince you, I suppose you as package maintainer
are in a far better position to contact upstream than I as a lowly user
(actually, not even that).  Sorry.

Ciao.                                                          Vincent.
-- 
Vincent Zweije <zweije at xs4all.nl>    | "If you're flamed in a group you
<http://www.xs4all.nl/~zweije/>      | don't read, does anybody get burnt?"
[Xhost should be taken out and shot] |            -- Paul Tomblin on a.s.r.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20080616/f92386ee/attachment.pgp