[Debian-med-packaging] Bug#660309: tophat: broken code in configure script for determining CFLAGS

[peter green]

Package: tophat
Version: 1.4.1-1
Severity: serious
tags: patch

The configure.ac file in your package contains code to determine c 
compiler flags based on architecture. Unfortunately this code is 
horriblly broken.

On i386 the configure script uses -march=i686. This is not acceptable in 
debian as debian supports (at least in theory) processors down to the 486.

On all other debian architectures the configure script falls into a 
broken* fallback test for -m64. This test always passes causing the 
build to use -m64. This is tolerable (but pointless) on amd64 and 
kfreebsd-amd64 and breaks the build on all other architectures.

Even more strangely the code seems to be setup to define 
_FILE_OFFSET_BITS=64 on unknown architectures that don't support -m64 
(though due to the broken -m64 test that codepath is never used) but not 
on x86.

The attatched patch simply removes the broken checking code and leaves 
EXT_CFLAGS empty on all architectures. I have tested that with this 
patch the package builds on kfreebsd-i386.

* I have not determined exactly how it is broken but it seems to be 
passing on all architectures. My suspsicion is the CFLAGS set before the 
test aren't actually being used.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_crazy_cflag_code.patch
Type: text/x-diff
Size: 1957 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20120218/fb33a24a/attachment.patch>